Fix search command highlighting for single characters #14930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
force-pushed
the
fix-search-command-for-single-characters
branch
from
33ea973
to
b8d9e6d
Compare
adfoster-r7
force-pushed
the
fix-search-command-for-single-characters
branch
from
b8d9e6d
to
d63ff8a
Compare
adfoster-r7
changed the title
|
Verified that I could reproduce the original issue and that this fixes it. Quick note, that it didn't look like all single letter queries would reproduce the error, but that at least
I'll have this landed shortly, thanks @adfoster-r7 ! |
Release NotesFixed a bug where the highlighting in msfconsole's search command would break when the search term was certain single letter queries. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14922
Thanks to @pingport80 for raising the issue and pointing to where the code was having issues over a quick slack chat
Before
After
Verification
List the steps needed to make sure this thing works
search a eternal