CookieJar cleanup #15165
Merged
CookieJar cleanup #15165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
May 12, 2021
| expect(v).to eq(cookie.domain.nil?) | ||
| end | ||
|
|
||
| it "will return false if url with http protocol is passed with a domain that doesn't match the cookie domain" do |
There was a problem hiding this comment.
Looks like this file didn't have rubocop run on it 🤷
Release NotesAdded documentation for the new cookie jar implementation, which is available for http-based modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with the new CookieJar feature:
HttpCookieattr_hashoptions to use the class setters.HttpCookie&HttpCookieJarmethods.Also done but not part of this PR:
send_request_cgicookie features