Fix RPORT tab completion crash when connected to remote dataservice

[agalway-r7]

Fixes #15075

Removes usage of has_host?from the option_values_target_ports module of module_option_tab_completion.

This is the last remaining use of the method in the code base, so I deleted the original method definition since it's breaking things and we don't want it being used in the future.

Verification

List the steps needed to make sure this thing works

• Start msfconsole
• use auxiliary/scanner/ssh/ssh_login
• set RHOSTS 1.1.1.1
• set RPORT <TAB>
• Ensure that no error is thrown, and that a RPORT number is populated if appropriate

[adfoster-r7]

Looks like this needs to handle the msfconsole crashing on tab completion still 👀

[agalway-r7]

Can anyone explain why we were returning a random port suggestion when we couldn't find one in the DB?

[gwillcox-r7]

Can confirm that with new changes this fixes the tab completion error. master was still crashing with the error shown in #15075, but testing on this PR had the following result:

msf6 > use auxiliary/scanner/ssh/ssh_login
msf6 auxiliary(scanner/ssh/ssh_login) > set RHOSTS 1.1.1.1
RHOSTS => 1.1.1.1
msf6 auxiliary(scanner/ssh/ssh_login) > set RPORT 22 

[adfoster-r7]

Looks like this wraps the previous readline completion proc in a try/catch, not sure if that's what we want to happen here? 👀

[agalway-r7]

No it's wrapping the tab_complete_proc that gets passed in with initialize. The previous tab_complete_proc is getting overwritten here

[adfoster-r7]

Tested with:

msfconsole
db_nmap 127.0.0.1

use auxiliary/scanner/ssh/ssh_login
set RHOSTS 127.0.0.1
set RPORT <TAB>

set RHOSTS 1.1.1.1
set RPOT <tab>

[adfoster-r7]

@msjenkins-r7 retest this please

[adfoster-r7]

Release Notes

Fixed a bug where msfconsole would crash when connected to a remote dataservice and tab completing possible RPORT values.