Support spaces in user input for msfdb #15196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously having spaces in the path to framework install would result in errors running msfdb, this PR addresses that issue along with having spaces in options passed into the script
Example of current functionality, you can see when running
![image](https://user-images.githubusercontent.com/19910435/118260553-6103a180-b4aa-11eb-8dbe-957460dc2375.png)
reinit
which metasploit in a folder with spaces in the name it fails to completeand after:
![image](https://user-images.githubusercontent.com/19910435/118260929-d4a5ae80-b4aa-11eb-8c7d-90e78b5065d7.png)
Verification
./msfdb delete --component=all
# This is destructive if you have important data in your db do this in a VM./msfdb reinit --component=all
# Both components should start with no issues--ssl-key-file
and--ssl-cert-file
options where they lie in a path with a space in it