Update local exploit suggester to handle nil targets

[sjanusz-r7]

This PR fixes an issue with local_exploit_suggester, where it would crash if i encountered a module with a nil target property.

Before

When a module returns a nil target:

After

Verification

List the steps needed to make sure this thing works

• Apply this patch

diff --git a/lib/msf/core/exploit.rb b/lib/msf/core/exploit.rb
index 8f7891cef2..94b8bbdd86 100644
--- a/lib/msf/core/exploit.rb
+++ b/lib/msf/core/exploit.rb
@@ -634,6 +634,10 @@ class Exploit < Msf::Module
   # default target, that one will be automatically used.
   #
   def target
+    if self.fullname == "exploit/windows/local/ms10_092_schelevator"
+      return nil
+    end
     if self.respond_to?(:auto_targeted_index)
       if auto_target?
         auto_idx = auto_targeted_index

• Start msfconsole
• Get a session
• Use local_exploit_suggester
• Verify the exploit suggester doesn't crash

[adfoster-r7]

Out of interest, what's the rationale behind special casing this exception in particular? 👀

[adfoster-r7]

I know it was there previously, but was it investigated in more detail whether it's needed still? 🕵️

[agalway-r7]

If I'm not confuddled, it's that this error indicates the session is borked and that you can't run any more checks, where as any other error indicates it was just the check that had an issue

[adfoster-r7]

It's raised in other circumstances too:

meterpreter > run post/windows/manage/migrate

[*] Running module against HOME-F006222D6C
[*] Current server process: webappmon.exe (7064)
[*] Spawning notepad.exe process to migrate to
[-] Post failed: Rex::Post::Meterpreter::RequestError stdapi_sys_process_execute: Operation failed: Access is denied.
[-] Call stack:
[-]   /projects/exploiting/trunk/lib/rex/post/meterpreter/extensions/stdapi/sys/process.rb:163:in `execute'
[-]   (eval):80:in `create_temp_proc'
[-]   (eval):49:in `run'
=end

[adfoster-r7]

Just waiting on jenkins 🐌

[adfoster-r7]

@msjenkins-r7 retest this please

[adfoster-r7]

Release Notes

Updates the local exploit suggester to gracefully handle modules raising unintended exceptions and nil target information