Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handing to rdp_web_login.py to handle malformed NetNTLM messages #15727

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Add error handing to rdp_web_login.py to handle malformed NetNTLM messages #15727

merged 4 commits into from
Jan 18, 2022

Commits on Jan 18, 2022

  1. Added error handling to catch malformed NTML hashes 

    As mentioned in rapid7#15720 with some NTML responses the code crashes, unable to enumerate the domain. To prevent this behavior a try and except block was added, to inform the user about the crash.
    @NeffIsBack @smcintyre-r7
    NeffIsBack authored and smcintyre-r7 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    9c83c7c View commit details
    Browse the repository at this point in the history

  2. Apply additional error handling and improve quality of error messages

    @gwillcox-r7 @smcintyre-r7
    gwillcox-r7 authored and smcintyre-r7 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    bbc789e View commit details
    Browse the repository at this point in the history

  3. Add further input validation

    @gwillcox-r7 @smcintyre-r7
    gwillcox-r7 authored and smcintyre-r7 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    50eabd3 View commit details
    Browse the repository at this point in the history

  4. Parse the NTLM Type 1 message

    @smcintyre-r7
    smcintyre-r7 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    c446e83 View commit details
    Browse the repository at this point in the history