Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in new definitions to definitions.h #15844

Merged

Conversation

gwillcox-r7
Copy link
Contributor

@gwillcox-r7 gwillcox-r7 commented Nov 8, 2021

Add a proper THREADINFOCLASS definition, additional SYSTEM_INFORMATION_CLASS definitions, and a BIG_POOL_INFO definition, along with a few other minor changes.

This is needed for #15834 to contain proper definitions vs having to define things itself manually.

I could add a full definition of SYSTEM_INFORMATION_CLASS in and I do plan to do this eventually, however at 200+ system calls that need to be defined still I think this may take some time and not all of them are needed for this PR to work.

Verification

List the steps needed to make sure this thing works

  • Review the code
  • Make sure the definition file loads correctly.
  • Land me plx 😄

@smcintyre-r7 smcintyre-r7 self-assigned this Nov 8, 2021
….h including a proper THREADINFOCLASS definition, additional SYSTEM_INFORMATION_CLASS definitions, and a BIG_POOL_INFO definition
@gwillcox-r7 gwillcox-r7 force-pushed the update-windows-definitions-h-file branch from 9da3fe7 to 517b586 Compare November 8, 2021 22:47
@gwillcox-r7
Copy link
Contributor Author

Rebased into one commit and removed the BIG_POOL_INFO definition since I'm not 100% sure which one is correct or if I am getting it confused with another definition, and its fine for us to just define it within the exploit for the time being until we can get more clarity on this.

Copy link
Contributor

@smcintyre-r7 smcintyre-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. I spot checked some of the definitions and made sure that the code still compiles for the previous exploit that needed it.

I'll have this landed shortly.

@smcintyre-r7 smcintyre-r7 added the rn-no-release-notes no release notes label Nov 9, 2021
@smcintyre-r7 smcintyre-r7 merged commit 4c937c9 into rapid7:master Nov 9, 2021
@gwillcox-r7 gwillcox-r7 deleted the update-windows-definitions-h-file branch November 9, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants