Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tcp uri scheme for setting rhosts #15965

Merged

Conversation

adfoster-r7
Copy link
Contributor

Adds a tcp uri scheme for setting rhosts. This is a more generic version of the protocol specific schemas such as mysql, which also set a default port, database config etc. The tcp scheme just sets username, password, and the port if it's specified.

This will be useful for exploiting remote hosts which require a user/password/port all at once - but don't have a specific schema already defined

Verification

use auxiliary/scanner/http/title
run tcp://example.com

Copy link
Contributor

@gwillcox-r7 gwillcox-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just had a few comments of concern to double check before this is landed.

spec/lib/msf/core/rhosts_walker_spec.rb Show resolved Hide resolved
lib/msf/core/rhosts_walker.rb Show resolved Hide resolved
@gwillcox-r7 gwillcox-r7 self-assigned this Dec 16, 2021
@gwillcox-r7
Copy link
Contributor

Comments resolved, will test this and land it now.

@gwillcox-r7
Copy link
Contributor

Working as expected, will land this now.

@gwillcox-r7 gwillcox-r7 merged commit 0ee427d into rapid7:master Dec 16, 2021
@gwillcox-r7 gwillcox-r7 added enhancement rn-enhancement release notes enhancement labels Dec 16, 2021
@gwillcox-r7
Copy link
Contributor

Release Notes

Adds a TCP URI scheme for setting RHOSTS, which allows one to specify the username, password, and the port if it's specified as a string such as tcp://user:a b c@example.com which would translate into the username user, password a b c, and host example.com on the default port used by the module in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants