bash_profile_persistence: Add notes and resolve rubocop violations

[bcoles]

Removes a couple of quotes " in the module description. Not sure why they were there.

Resolved rubocop violations while I was at it. Also added notes, as missing notes is also a rubocop violation.

[adfoster-r7]

Looks like the description was initially committed with extra quotes, and Rubocop just formatted it nicely

metasploit-framework/modules/exploits/linux/local/bash_profile_persistence.rb

Lines 17 to 22 in e577de4

	'Description' => %q{"
	This module writes an execution trigger to the target's Bash profile.
	The execution trigger executes a call back payload whenever the target
	user opens a Bash terminal. A handler is not run automatically, so you
	must configure an appropriate exploit/multi/handler to receive the callback.
	"},

[adfoster-r7]

Awaiting sanity tests to pass

[bcoles]

I'm going to presume this change is ok. If it isn't we'll find out soon enough.

[jmartin-tech]

Suggested change

	rescue StandardError
	rescue NoMethodError

Since sysinfo will return nil if not on meterpreter this should just return a NoMethodError for [].

[bcoles]

Since sysinfo will return nil if not on meterpreter this should just return a NoMethodError for [].

Fixed.

[jmartin-tech]

Release Notes

Module notes added to bash_profile_persistence now describe impacts of utilizing the module in a target environment.