Fix dcerpc hidden scanner #16016
Merged
Fix dcerpc hidden scanner #16016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwatters-r7
commented
Jan 5, 2022
| @@ -3,6 +3,8 @@ | |||
| # Current source: https://github.com/rapid7/metasploit-framework | |||
| ## | |||
|
|
|||
| require 'English' | |||
| require 'English' | |||
There was a problem hiding this comment.
I am unclear why rubocop added double English.....?
There was a problem hiding this comment.
No idea. rubocop doesn't complain when both are removed.
$ rubocop modules/auxiliary/scanner/dcerpc/hidden.rb
Inspecting 1 file
W
Offenses:
modules/auxiliary/scanner/dcerpc/hidden.rb:76:11: W: Lint/UselessAssignment: Useless assignment to variable - res.
res = dcerpc.call(0, NDR.long(0) * 128)
^^^
modules/auxiliary/scanner/dcerpc/hidden.rb:84:9: W: Lint/RescueException: Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
rescue ::Exception => e ...
^^^^^^^^^^^^^^^^^^^^^^^
modules/auxiliary/scanner/dcerpc/hidden.rb:114:3: W: Lint/RescueException: Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
rescue ::Exception => e ...
^^^^^^^^^^^^^^^^^^^^^^^
1 file inspected, 3 offenses detected
bwatters-r7
force-pushed
the
fix-dcerpc_hidden-scanner
branch
from
20e03f5
to
f17d460
Compare
|
Confirm that this was broken when RHOSTS scanning came in. I monkeyed around it at some point to get it to work on engagement - something gross was done 😄. Thank you for fixing this. |
|
Changes look good to me, and the Output of module run on `master`Output of module run after fix |
Release NotesThis fixes an issue in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a bug brought up in the pentest huddle. It turns out that this module did not originally have an RHOST value. I think what happened was that later in changes to RHOST and RHOSTS, RHOST became synonymous with RHOSTS, so the original removal of RHOST as a value then took out RHOSTS.
This change just takes out the RHOST removal and pulls out only RPORT, which is populated by talking to the RPC service.
This is a one-line change- to make life easier, I separated the actual fix from the rubocop fixes into two different commits.
For testing, it is as simple as:
use use auxiliary/scanner/dcerpc/hiddenshow optionsset RHOST <ip>runset RHOSTS <ip>I had little luck targeting workstations, but lots of luck targeting servers. Specifically, the best target for me was a Server 2016 VM running exchange:
Wall of Text