-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the generate command's tab completion for -o and -f #16027
Conversation
1bf18f2
to
41b2bc4
Compare
Thanks @zeroSteiner for fixing this! I was able to confirm tab completion works as expected for both
I have a quick question before it lands: is having the current modules valid datastore options necessary for these options? I believe it would required a deeper change in Framework to remove them from tab completion, just checking. |
Yeah it's kind of necessary because the datastore options for the module are also valid arguments. You can see them used in the |
Release NotesThis fixes an issue with tab completion for the |
Fixes #16022. This updates the tab completion routine for the
generate
command that is provided by payload modules. It removes completion for the invalid-t
flag, fixes the-f
flag and marks-o
for completion as a file path.Verification
List the steps needed to make sure this thing works
msfconsole
use payload/python/meterpreter/reverse_tcp
generate -o
and hit tab, see the contents of the current working directory suggested (along with the current modules valid datastore options)generate -f
and hit tab, see the supported formats suggested (again, along with the current modules valid datastore options)Demo