Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove obsolete activerecord patch #1611

Closed
wants to merge 4 commits into from

2 participants

limhoff-r7 added some commits
@limhoff-r7 limhoff-r7 Allow use of rake db tasks
[#46224565]

The following rake tasks are added and work similar to how they work in
rails apps:
* db:create
* db:drop
* db:migrate
* db:migrate:status
* db:rollback
* db:schema:dump
* db:schema:load
* db:seed (but no db seeds defined at this time)
* db:setup
* db:version

The hidden task db:test:prepare is also available, which means `rake
spec` can depend on it so that the test database is dropped and
recreated from the development database when running specs (Although
there are yet to be database tests, this branch is in preparation for
that work that will be split between multiple developers.)
2604fad
@limhoff-r7 limhoff-r7 Configure travis-ci to use database for rake spec
[#46224565]
0f6b053
@limhoff-r7 limhoff-r7 Specs for activerecord patch
[#46141013]

Spec the desired behavior for ConnectionPool prior to removing the patch
to sync with upstream 3.2.12.
f1a4fd9
@limhoff-r7 limhoff-r7 Remove active_record patch
[#46141013]

Version 3.2.12 of activerecord contains the changes that the original
patch made so the patch is no longer needed.
2075a7b
@limhoff-r7
Collaborator

This pull request is a superset of #1592 so if this pull request is accepted, then 1592 will be closed automatically.

@limhoff-r7
Collaborator

Verification Steps:

Because this pull request is a superset of #1592, please complete its Verification Step before proceeding to the below steps.

  • rake spec
  • VERIFY no errors
@todb-r7
Owner

Looks good -- especially love the part where you re-implemented the connection pool test as a rake spec to prove that the patch is no longer needed. Thanks!

@todb-r7 todb-r7 referenced this pull request from a commit
@todb todb Merges 'bug/obsolete-activerecord-patch'
Not only does this remove the patch, but adds in specs to cover the test
cases that the patch resolved. Verified all steps and landed #1592 before
landing #1611, so this is complete.

[Closes #1611]
6618c09
@todb-r7 todb-r7 closed this pull request from a commit
@todb todb Merges 'bug/obsolete-activerecord-patch'
Not only does this remove the patch, but adds in specs to cover the test
cases that the patch resolved. Verified all steps and landed #1592 before
landing #1611, so this is complete.

[Closes #1611]
6618c09
@todb-r7 todb-r7 closed this in 6618c09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 14, 2013
  1. @limhoff-r7

    Allow use of rake db tasks

    limhoff-r7 authored
    [#46224565]
    
    The following rake tasks are added and work similar to how they work in
    rails apps:
    * db:create
    * db:drop
    * db:migrate
    * db:migrate:status
    * db:rollback
    * db:schema:dump
    * db:schema:load
    * db:seed (but no db seeds defined at this time)
    * db:setup
    * db:version
    
    The hidden task db:test:prepare is also available, which means `rake
    spec` can depend on it so that the test database is dropped and
    recreated from the development database when running specs (Although
    there are yet to be database tests, this branch is in preparation for
    that work that will be split between multiple developers.)
Commits on Mar 15, 2013
  1. @limhoff-r7
Commits on Mar 18, 2013
  1. @limhoff-r7

    Specs for activerecord patch

    limhoff-r7 authored
    [#46141013]
    
    Spec the desired behavior for ConnectionPool prior to removing the patch
    to sync with upstream 3.2.12.
  2. @limhoff-r7

    Remove active_record patch

    limhoff-r7 authored
    [#46141013]
    
    Version 3.2.12 of activerecord contains the changes that the original
    patch made so the patch is no longer needed.
Something went wrong with that request. Please try again.