Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix faulty URL ref #16078 removed faulty url #16123

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

AtmegaBuzz
Copy link
Contributor

@AtmegaBuzz AtmegaBuzz commented Jan 29, 2022

fix faulty URL ref #16078 , i searched for FULL_DISC tool in Cisco but i cant find anything related to this so i removed it. if that is meant by the issue.

Tell us what this change does. If you're fixing a bug, please mention
the github issue number.

Please ensure you are submitting from a unique branch in your repository to master in Rapid7's.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use exploit/windows/smb/ms08_067_netapi
  • ...
  • Verify the thing does what it should
  • Verify the thing does not do what it should not
  • Document the thing and how it works (Example)

If you are opening a PR for a new module that exploits a specific piece of hardware or requires a complex or hard-to-find testing environment, we recommend that you send us a demo of your module executing correctly. Seeing your module in action will help us review your PR faster!

Specific Hardware Examples:

  • Switches
  • Routers
  • IP Cameras
  • IoT devices

Complex Software Examples:

  • Expensive proprietary software
  • Software with an extensive installation process
  • Software that requires exploit testing across multiple significantly different versions
  • Software without an English language UI

We will also accept demonstrations of successful module execution even if your module doesn't meet the above conditions. It's not a necessity, but it may help us land your module faster!

Demonstration of successful module execution can take the form of a packet capture (pcap) or a screen recording. You can send pcaps and recordings to msfdev@metasploit.com. Please include a CVE number in the subject header (if applicable), and a link to your PR in the email body.
If you wish to sanitize your pcap, please see the wiki.

 fix faulty URL ref rapid7#16078 , i searched for FULL_DISC tool in Cisco but i cant find anything related to this so i removed it. if that is meant by the issue.
@bcoles
Copy link
Contributor

bcoles commented Jan 29, 2022

i searched for FULL_DISC tool in Cisco but i cant find anything related to this so i removed it. if that is meant by the issue.

FULL_DISC was a placeholder which was meant to be replaced with the Full Disclosure mailing list archive URL which had not yet been published at the time the module was merged.

https://seclists.org/fulldisclosure/2019/Aug/36

@AtmegaBuzz
Copy link
Contributor Author

@bcoles oo now i understood, thnx for clarifying sir.

@AtmegaBuzz
Copy link
Contributor Author

should i close the pr

@gwillcox-r7
Copy link
Contributor

@AtmegaBuzz I believe the appropriate fix here would be to replace the text FULL_DESC with the text https://seclists.org/fulldisclosure/2019/Aug/36. I would be happy to merge in this PR if that change was made.

@smcintyre-r7 smcintyre-r7 self-assigned this Feb 1, 2022
@smcintyre-r7 smcintyre-r7 merged commit 70d4013 into rapid7:master Feb 1, 2022
@smcintyre-r7
Copy link
Contributor

Added the URL in commit 06fb748. Thanks for this patch @AtmegaBuzz !

@smcintyre-r7
Copy link
Contributor

Release Notes

This fixes the missing full disclosure reference URL in the exploit/linux/http/cisco_ucs_rce module.

@smcintyre-r7 smcintyre-r7 added the rn-fix release notes fix label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy module rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants