Fix Meterpreter module tests on Windows host

[adfoster-r7]

Fixes an edge case when reading files on Windows, and fixes Ruby 3 crashes when reading files.

Windows fix

The file upload support of Meterpreter was broken on windows machines, which was doing additional EOL<->CRLF conversions on windows:

"b"  Binary file mode
     Suppresses EOL <-> CRLF conversion on Windows. And
     sets external encoding to ASCII-8BIT unless explicitly
     specified.

This meant the expected hashes didn't match

Verification

Open msfconsole on windows, and open a Python Meterpreter on windows:

use python/meterpreter_reverse_tcp
generate -o shell.py -f raw lhost=127.0.0.1
to_handler
python3 shell.py

Run the test:

loadpath test/modules
use test/meterpreter
run session=-1

Verify the md5/sha1 tests pass now

[sjanusz-r7]

LGTM!

Before

msf6 post(test/meterpreter) > run session=-1

[*] Running against session -1
[*] Session type is meterpreter and platform is windows
[+] should enumerate supported core commands
[+] should support 3 or more core commands
[+] should return its own process id
[+] should return a list of processes
[+] should return a user id
[+] should return a sysinfo Hash
[+] should return network interfaces
[+] should have an interface that matches session_host
[+] should return network routes
[+] should return the proper directory separator
[+] should return the current working directory
[+] should list files in the current directory
[+] should stat a directory
[+] should create and remove a dir
[+] should change directories
[+] should create and remove files
[-] FAILED: should upload a file
[+] should move files
[+] should copy files
[-] FAILED: should do md5 and sha1 of files
[-] Passed: 18; Failed: 2
[*] Post module execution completed

After

msf6 post(test/meterpreter) > run session=-1

[*] Running against session -1
[*] Session type is meterpreter and platform is windows
[+] should return its own process id
[+] should return a list of processes
[+] should return a user id
[+] should return a sysinfo Hash
[+] should return network interfaces
[+] should have an interface that matches session_host
[+] should return network routes
[+] should return the proper directory separator
[+] should return the current working directory
[+] should list files in the current directory
[+] should stat a directory
[+] should create and remove a dir
[+] should change directories
[+] should create and remove files
[+] should upload a file
[+] should move files
[+] should copy files
[+] should do md5 and sha1 of files
[+] should enumerate supported core commands
[+] should support 3 or more core commands
[*] Passed: 20; Failed: 0
[*] Post module execution completed

[sjanusz-r7]

Release Notes

Fixes an edge case when reading files on Windows, and fixes Ruby 3 crashes when reading files.