Fix Meterpreter module tests on Windows host #16197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case when reading files on Windows, and fixes Ruby 3 crashes when reading files.
Windows fix
The file upload support of Meterpreter was broken on windows machines, which was doing additional EOL<->CRLF conversions on windows:
This meant the expected hashes didn't match
Verification
Open msfconsole on windows, and open a Python Meterpreter on windows:
Run the test:
Verify the md5/sha1 tests pass now