Add mode to file and io reads and writes #16343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Mar 14, 2022
adfoster-r7
reviewed
Mar 14, 2022
sjanusz-r7
force-pushed
the
add-mode-to-file-and-io-reads-and-writes
branch
6 times, most recently
from
8bbffce
to
75ec339
Compare
sjanusz-r7
force-pushed
the
add-mode-to-file-and-io-reads-and-writes
branch
from
75ec339
to
18d715b
Compare
sjanusz-r7
commented
Mar 16, 2022
| @@ -77,7 +77,7 @@ def process_file(base64_file, save_path) | |||
| begin | |||
| # If we are running the data service on the same box this will ensure we only write | |||
| # the file if it is somehow not there already. | |||
| unless File.exists?(save_path) && File.read(save_path) == decoded_file | |||
| unless File.exists?(save_path) && File.read(save_path, mode: 'rb') == decoded_file | |||
| File.open(save_path, 'w+') { |file| file.write(decoded_file) } | |||
There was a problem hiding this comment.
Suggested change
| File.open(save_path, 'w+') { |file| file.write(decoded_file) } | |
| File.write(save_path, decoded_file, mode: 'wb') |
sjanusz-r7
commented
Mar 16, 2022
| @@ -166,7 +166,7 @@ def mssql_upload_exec(exe, debug=false) | |||
|
|
|||
| print_status("Warning: This module will leave #{var_payload}.exe in the SQL Server %TEMP% directory") | |||
| print_status("Writing the debug.com loader to the disk...") | |||
| h2b = File.read(datastore['HEX2BINARY'], File.size(datastore['HEX2BINARY'])) | |||
| h2b = File.read(datastore['HEX2BINARY'], File.size(datastore['HEX2BINARY']), mode: 'rb') | |||
There was a problem hiding this comment.
Let's revert this as the line below splits on \n
|
Closing this as these changes are now consolidated into a single PR here: #16325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mode to
File.readandFile.writecalls, as per the comment here: #16325 (comment)Verification
msfconsoleusea module that is currently failing due toFile.readorFile.writecalls