-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing payload tests #16398
Merged
Merged
add missing payload tests #16398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
903f317
to
67cee60
Compare
A number of recent payload adds do not conform the patterns used for suggesting spec configurations. Manually added these tests to remove warning in rspec run.
67cee60
to
cb5d449
Compare
@msjenkins-r7 test this please. |
gwillcox-r7
reviewed
Apr 6, 2022
Seems this is working as expected:
|
gwillcox-r7
approved these changes
Apr 7, 2022
Release NotesA number of recent payload adds did not conform the patterns used for suggesting spec configurations. Tests for these payloads have now been manually added to ensure they will be appropriately tested as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of recent payload adds do not conform the patterns
used for suggesting spec configurations. Manually added these
tests to remove warning in rspec run.
Verification
List the steps needed to make sure this thing works
bundle exec rspec spec/modules/payloads_spec.rb