Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve regex parsing in lotus_domino_hashes #16505

Merged
merged 3 commits into from May 19, 2022

Commits on Apr 26, 2022

  1. Improve regex parsing in lotus_domino_hashes

    * The closing quotes after the `VALUE` attribute were not escaped. This
      commit adds them
    * The regex assumed that the short name does not contain whitespace.
      I am looking at a Domino instance where the short name DOES contain
      whitespace. This commit changes the regex such that the value is
      assumed to not contain a quote before the closing quote. Of course,
      there could be an escaped quote inside quotes in the HTML source, but
      if we want to do it properly, we'd need an HTML parser which exceeds
      my modest ruby skills.
    * The fields `$dspHTTPPassword` and `dspHTTPPassword` (without the
      dollar sign) can both contain the hash. The code assumed that only up
      to one of those fields contain a hash. This leads to the hash being
      printed twice in the output in my case.
    AdrianVollmer committed Apr 26, 2022
    Copy the full SHA
    dfdd57e View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Update modules/auxiliary/scanner/lotus/lotus_domino_hashes.rb

    Co-authored-by: jheysel-r7 <Jack_Heysel@rapid7.com>
    AdrianVollmer and jheysel-r7 committed Apr 28, 2022
    Copy the full SHA
    267f7a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Copy the full SHA
    d6547c0 View commit details
    Browse the repository at this point in the history