Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure HTML is escaped in markdown codeblocks #16509

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Ensure HTML is escaped in markdown codeblocks #16509

merged 1 commit into from
Apr 27, 2022

Conversation

adfoster-r7
Copy link
Contributor

Ensure the info -d correctly escapes HTML in code blocks

Before

image

After

image

Verification

msfconsole
use windows/smb/smb_relay
info -d

@adfoster-r7 adfoster-r7 mentioned this pull request Apr 27, 2022
Merged
5 tasks
@smcintyre-r7 smcintyre-r7 self-assigned this Apr 27, 2022
@smcintyre-r7
Copy link
Contributor

Confirmed it's working now. Changes LGTM, thanks for fixing this!

@smcintyre-r7 smcintyre-r7 merged commit 21f8494 into rapid7:master Apr 27, 2022
@space-r7 space-r7 added the rn-fix release notes fix label Apr 28, 2022
@space-r7
Copy link
Contributor

Release Notes

This ensures proper escaping of HTML in code blocks that are produced by the info -d command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smcintyre-r7 smcintyre-r7

Labels
bug rn-fix release notes fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adfoster-r7 @smcintyre-r7 @space-r7