Add SAN support to impersonate_ssl module

[dismantl]

Add Subject Alternative Names (SAN) support to impersonate_ssl module

Verification

List the steps needed to make sure this thing works

• Start msfconsole
• use auxiliary/gather/impersonate_ssl
• set RHOSTS www.example.com
• set ADD_SAN alt.example.com,1.2.3.4
• run
• Verify the SAN entries were added to the certificate:

$ sudo openssl x509 -noout -text -in /root/.msf4/loot/20220608112036_default_93.184.216.34_93.184.216.34_ce_782579.crt
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            06:1e:8e:b2:79:6f:05:87:ed:80:59:2f:15:00:32:4f:8e
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: C = US, ST = California, L = Los Angeles, O = Internet\C2\A0Corporation\C2\A0for\C2\A0Assigned\C2\A0Names\C2\A0and\C2\A0Numbers, CN = www.example.org
        ...
        X509v3 extensions:
            X509v3 Basic Constraints: critical
                CA:FALSE
            X509v3 Subject Key Identifier: 
                41:A5:A7:9F:58:11:39:13:14:BD:F5:A7:1B:C7:93:0E:BE:4A:00:E0
            X509v3 Subject Alternative Name: 
                DNS:alt.example.com, IP Address:1.2.3.4
    Signature Algorithm: sha256WithRSAEncryption
         07:e1:02:ea:15:e0:77:ac:15:4b:da:13:c4:59:87:f6:10:93:
         ...

[gwillcox-r7]

Suggested change

	san = san =~ Resolv::IPv4::Regex || san =~ Resolv::IPv6::Regex ? "IP:#{san}" : "DNS:#{san}"
	san = (san =~ Resolv::IPv4::Regex || san =~ Resolv::IPv6::Regex) ? "IP:#{san}" : "DNS:#{san}"

Suggestion for making this a little easier to read.

[gwillcox-r7]

See https://support.f5.com/csp/article/K13471 for an example of how the IP and DNS fields might appear in a sample certificate. Adding this comment for future traveler's reference.

[gwillcox-r7]

Changes look good and was able to replicate and confirm the new certificate was generated with the expected format. Thanks for submitting this improvement, will get this landed now!

[gwillcox-r7]

Release Notes

The impersonate_ssl module has been enhanced to allow it to add Subject Alternative Names (SAN) fields to the generated SSL certificate.