-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datastore option for Jenkins home directory #17681
Conversation
Also: performing |
There seems to be a lot of unrelated style changes introduced in this PR. Please run |
Thanks for your pull request! Before this pull request can be merged, it must pass the checks of our automated linting tools. We use Rubocop and msftidy to ensure the quality of our code. This can be ran from the root directory of Metasploit:
You can automate most of these changes with the
Please update your branch after these have been made, and reach out if you have any problems. |
…ional value that a user can suggest the home directory.
I am unsure why the commit contains styling changes at all, and I did not change anything other than the find_home function and the top of the file.. I think that rubocop may have run but without parsing .rubocop.yaml. |
rubocop was run over the modules a couple of weeks ago: You've likely forked and performed modifications before these changes were applied, which resulted in the rubocop changes being reverted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but had one concern that might not be related to this PR per say.
Change the default Windows location to C:\ProgramData\Jenkins\.jenkins\.
Change Windows default to C:\ProgramData\Jenkins\.jenkins.
Tested against Windows 10 and Jenkins Docker image version 2.414. Windows
Docker
|
Co-authored-by: cgranleese-r7 <69522014+cgranleese-r7@users.noreply.github.com>
Release NotesThis PR adds a new datastore option for Jenkins home directory to the |
This patch adds a new option to the jenkins_gather.rb script, allowing a
user to specify the "jenkins home" directory, instead of running a potentially
time-and-resource-consuming "find /" command. Default directories are
now also included.
This patch is inspired by an environment where the "find /" command was
taking too long, and there was no way to set a configuration, despite
the correct directory being known. This patch also now allows for
alternative Jenkins directories to be gathered, not just the first one
found by `find'.