tools: modules: committer_count: Parse date argument with Time.parse #17830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure when or why this broke. This tool has had no meaningful updates since 2013.
Parsing the date in format
YYYY-MM-DD
is kind of important, as this is what the script does by default when no argument is provided:metasploit-framework/tools/modules/committer_count.rb
Line 51 in e2e8568
This crashes with
Time.new
. It does not crash withTime.parse
.Before
After