Improve check_host return code handling #17868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwillcox-r7
reviewed
Apr 12, 2023
gwillcox-r7
force-pushed
the
Delete_Unnecessary_Log_in_ms15_034_http_sys_memory_dump
branch
from
e4a2629
to
066883e
Compare
gwillcox-r7
force-pushed
the
Delete_Unnecessary_Log_in_ms15_034_http_sys_memory_dump
branch
from
066883e
to
d535bb8
Compare
gwillcox-r7
added
enhancement
rn-enhancement
gwillcox-r7
changed the title
Release NotesThe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this code is not clear the target is vulnerable or not.
It can cause confusion to users.
It is also unnecessary code because it is verified in the code that follows.
In conclusion, I think it's better to delete it.