Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/sap xml parsing #1788

Merged
merged 2 commits into from
May 2, 2013
Merged

Bug/sap xml parsing #1788

merged 2 commits into from
May 2, 2013

Commits on May 2, 2013

  1. Revert removal of the SAP module 

    This reverts commit 26da7a6.
    Tod Beardsley committed May 2, 2013
    Configuration menu
    Copy the full SHA
    902cd7e View commit details
    Browse the repository at this point in the history

  2. Rework parse_xml 

    We try to avoid using Nokogiri in modules due to the sometimes
uncomfortable dependencies it creates with particular compiled libxml
versions. Also, the previous parse_xml doesn't seem to be correctly
skipping item entries with blank names.

I will paste the test XML in the PR proper, but do check against a live
target to make sure I'm not screwing it up.
    Tod Beardsley committed May 2, 2013
    Configuration menu
    Copy the full SHA
    7579b57 View commit details
    Browse the repository at this point in the history