Replace [System.IO.File]::Exists with Test-Path #17980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exists? method in post/file has a different implementation for
PSH sessions than other shells which are testing for the existence
of a path, not the presence of a file.
Fix this by replacing [System.IO.File]::Exists with Test-Path.
Testing:
```
PS C:\Windows\system32> [System.IO.File]::Exists("C:\")
False
PS C:\Windows\system32>test-path C:\
PS C:\Windows\system32> test-path C:\
True
```
smcintyre-r7
added
library
bug
powershell
smcintyre-r7
approved these changes
May 11, 2023
There was a problem hiding this comment.
Changes look good to me.
Before:
[1] pry(#<Msf::Modules::Post__Test__File::MetasploitModule>)> exist?("C:\\")
=> false
After:
[1] pry(#<Msf::Modules::Post__Test__File::MetasploitModule>)> exist?("C:\\")
=> true
I also ran the post/test/file test module. The same number of tests pass and fail before and after this change. I think there are more updates that need to be made for those to all run smoothly but this is a step in the right direction and makes a tangible improvement.
Release NotesThis fixes the file system path check used by Powershell sessions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exists? method in post/file has a different implementation for PSH sessions than other shells which are testing for the existence of a path, not the presence of a file.
Fix this by replacing [System.IO.File]::Exists with Test-Path.
Testing: