Fix missing return in HTTP CmdStagers #18030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch payloads are cooler, but this was missed in rapid7#13426.
wvu
commented
May 26, 2023
| @@ -42,7 +42,7 @@ def on_request_uri(cli, request) | |||
|
|
|||
| unless user_agent =~ agent_regex | |||
| print_status("Sending 404 to #{client}") | |||
| send_not_found(cli) | |||
| return send_not_found(cli) | |||
There was a problem hiding this comment.
It's on the same line because why not. Similar return value.
|
Should we deprecate this whole feature? |
|
Don't think we should deprecate: there's a slew of weird targets with strange constraints out there - so long as the code maintenance burden isn't overly cumbersome, my take is to keep legacy mechanisms available for academic reasons if nothing else. |
gwillcox-r7
approved these changes
May 30, 2023
|
Simple change be simple. Nice job fixing this! 👍 |
Release NotesA missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch payloads are cooler, but this was missed in #13426. (Edit: Because I'm a big dummy.)
FWIW, the client doesn't actually receive the payload. You can test with
curl -Aorwget -Uand aCmdStagerexploit.