Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UA strings for June 2023 #18118

Merged
merged 1 commit into from Jun 22, 2023
Merged

Conversation

smashery
Copy link
Contributor

@smashery smashery commented Jun 16, 2023

Update the UA strings for June 2023.

Verification

  • Make sure that HTTP payloads still generate fine, and that they use one of the new user agents.

'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36',
'Mozilla/5.0 (Macintosh; Intel Mac OS X 13_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36',
'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36',
'Mozilla/5.0 (Macintosh; Intel Mac OS X 13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question - are these artisanally sourced by opening up the browsers manually and grabbing the user agent strings? 👀

Just wondering if there's somewhere we could grab the values from programmatically if we wanted to automate updating these values

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ These include popularity/market share quotients so we can have "poplar UA's" and "rare UA's" generated dynamically for testing various targets. I'd like to get away from using static strings in our code for content put on the wire where possible, and having a data source get updated every quarter/whatever would be rather handy (can probably even wrap that in a gem).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I currently get these from https://www.whatismybrowser.com/guides/the-latest-user-agent/ - I'm sure there are more programmatic-friendly places to find them.

@cgranleese-r7
Copy link
Contributor

cgranleese-r7 commented Jun 22, 2023

Working as expected 👍

Before

image

After

image

@cgranleese-r7 cgranleese-r7 added the rn-enhancement release notes enhancement label Jun 22, 2023
@cgranleese-r7 cgranleese-r7 merged commit ace4c45 into rapid7:master Jun 22, 2023
31 checks passed
@cgranleese-r7
Copy link
Contributor

Release Notes

This PR updates the User Agent strings for June 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants