Add Ruby 3.3.0-preview1 to test suite #18147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
force-pushed
the
add-ruby-3.3.0-preview1-to-test-suite
branch
2 times, most recently
from
c3ead52
to
da0ff24
Compare
adfoster-r7
commented
Jun 28, 2023
| @@ -79,7 +79,7 @@ def decrypt_secret_data(secret, key) | |||
| j = key[j..j+7].length | |||
| end | |||
| end | |||
| dec_data_len = decrypted_data[0,4].unpack('<L').first | |||
| dec_data_len = decrypted_data[0,4].unpack('L<').first | |||
There was a problem hiding this comment.
Invalid Ruby pack/unpack directives (i.e. using Python's way of specifying endianness) are now raised as an error. There's a separate effort to fix all invalid uses of this, but for now I'm fixing the ones that fail the test suite.
adfoster-r7
commented
Jun 28, 2023
jvoisin
approved these changes
Jun 29, 2023
gwillcox-r7
approved these changes
Jun 29, 2023
adfoster-r7
force-pushed
the
add-ruby-3.3.0-preview1-to-test-suite
branch
from
da0ff24
to
085943b
Compare
adfoster-r7
added
rn-enhancement
Release NotesAdds support for Ruby 3.3.0-preview1 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #18043
Verification