Update PHP Meterpreter to correctly show file sizes for large files #18152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release NotesThis PR fixes a bug where the PHP Meterpreter would show the incorrect file size for very large files. |
|
@cgranleese-r7 In the testing steps above I was also finding this affected 10GB files, perhaps we can adjust the release notes a bit to account for this? Something like "very large files" might be generic enough to account for the flexibility here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where PHP Meterpreter would show the incorrect file size for files bigger than 20GB.
Pulls in:
Verification
Verification steps from rapid7/metasploit-payloads#665 (comment)