Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream LDAP query results #18309

Conversation

zeroSteiner
Copy link
Contributor

This updates the ldap_query module to stream the results instead of collecting them all at once. This should improve the UX of using the module in large target environments with 10s of thousands of accounts and the like.

Testing

  • Use davidprowe/BadBlood to populate an Active Directory DC with thousands of objects for targeting
  • Starting metasploit and load the ldap_query module
  • Run some queries that fetch 1,000 + objects and see that the results come back at a relatively stead pace not after a long pause and then a full dump

@cdelafuente-r7
Copy link
Contributor

Thanks @zeroSteiner! Everything looks good to me. I tested against a Windows 2019 Server setup as a Domain Controller and verified the results are dumped immediately without any delay. I'll go ahead and land it.

@cdelafuente-r7 cdelafuente-r7 added the rn-enhancement release notes enhancement label Aug 31, 2023
@cdelafuente-r7 cdelafuente-r7 merged commit 6a674f5 into rapid7:master Aug 31, 2023
37 checks passed
@cdelafuente-r7
Copy link
Contributor

Release Notes

This updates the ldap_query module to stream the results instead of collecting them all at once. This should improve the UX of using the module in large target environments with 10s of thousands of accounts and the like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants