Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove left behind debug logging from prometheus exporter #18378

Merged
merged 1 commit into from Sep 18, 2023
Merged

Remove left behind debug logging from prometheus exporter #18378

merged 1 commit into from Sep 18, 2023

Conversation

adfoster-r7
Copy link
Contributor

Remove left behind debug logging from prometheus exporter

Verification

There should no longer be logging in the bundle exec rspec ./spec/lib/msf/core/auxiliary/prometheus_spec.rb test

Randomized with seed 17250
Msf::Auxiliary::Prometheus ...............{"url"=>"http://example2.com/prometheus"}
{"url"=>"http://username:password@example1.com/prometheus"}
..................

@adfoster-r7 adfoster-r7 added the rn-fix release notes fix label Sep 18, 2023
@dwelch-r7 dwelch-r7 merged commit 0fc88a8 into rapid7:master Sep 18, 2023
55 of 57 checks passed
@dwelch-r7
Copy link
Contributor

Release Notes

Remove left behind debug logging from prometheus exporter

@h00die
Copy link
Contributor

h00die commented Sep 18, 2023

oops, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rn-fix release notes fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adfoster-r7 @dwelch-r7 @h00die