Remove $Id tags

[jlee-r7]

Also adds binary coding magic comment to a few files

[jvazquez-r7]

These $stderr.puts are intended in this pull request? I don't see lot of use of $stderr across msf/core code so just asking.

[todb]

certainly not. also the if statement here should be an unless anyway.
On May 20, 2013 6:55 PM, "Juan Vazquez" notifications@github.com wrote:

In lib/msf/core/payload/generic.rb:

@@ -211,10 +211,13 @@ def actual_arch
arch = nil

    if explicit_arch.nil? == false

•       $stderr.puts "explicit"
  

These $stderr.puts are intended in this pull request? I don't see lot of
use of $stderr across msf/core code so just asking.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1853/files#r4308363
.

[limhoff-r7]

Is the binary encoding related to Windows compatibility? Does Windows not support the utf-8 encoding? Or is the binary encoding our work-around so that pack and unpack only have to deal with single byte characters?

[wchen-r7]

I can just restore changes for tcp.rb and generic.rb, no prob.

[jlee-r7]

Yeah, definitely an oversight. I was testing @jvennix-r7 's payload stuff and apparently left some garbage in there. =(

Thanks for catching.