Update to rpc_plugin to use HashWithIndifferentAccess

[Lorenyx]

Fixes #18545

Verification

$ msfrpcd -a 127.0.0.1 -P root
[*] MSGRPC starting on 127.0.0.1:55553 (SSL):Msg...
[*] MSGRPC ready at 2023-11-16 22:07:52 -0600.
$ msfrpc -a 127.0.0.1 -P root
...
>> rpc.call('core.version')
=> {"version"=>"6.3.43-dev-", "ruby"=>"3.0.2 x86_64-linux 2021-07-07", "api"=>"1.0"}
>> rpc.call('plugin.load', 'msfd', {'ServerPort'=>44444})
=> {"result"=>"success"}
>> exit
$ netstat -tulpn
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name    
tcp        0      0 127.0.0.1:631           0.0.0.0:*               LISTEN      -                   
tcp        0      0 127.0.0.1:55553         0.0.0.0:*               LISTEN      9444/msfrpcd   # IP and port for msfrpcd
tcp        0      0 127.0.0.1:44444         0.0.0.0:*               LISTEN      9444/msfrpcd   # Actually accepts correct value
tcp        0      0 127.0.0.53:53           0.0.0.0:*               LISTEN      -                   
tcp        0      0 127.0.0.1:5433          0.0.0.0:*               LISTEN      6510/postgres

[sjanusz-r7]

Looks good to me, thanks for the PR and fixing the issue! 🎉 I've tested this on Kali 2023.4:

Before

metasploit-framework on  master via 💎 v3.0.5 via ⍱ 
❯ sudo bundle exec './msfrpcd -a 127.0.0.1 -P root'
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
[*] MSGRPC starting on 127.0.0.1:55553 (SSL):Msg...
[*] MSGRPC backgrounding at 2023-12-11 15:48:31 +0000...
[*] MSGRPC background PID 31245
                                                                                                                                                           

metasploit-framework on  master via 💎 v3.0.5 via ⍱ 
❯ sudo bundle exec './msfrpc -a 127.0.0.1 -P root' 
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
[*] The 'rpc' object holds the RPC client interface
[*] Use rpc.call('group.command') to make RPC calls

>> rpc.call('core.version')
=> {"version"=>"6.3.47-dev-453c8d8d69", "ruby"=>"3.1.2 x86_64-linux-gnu 2022-04-12", "api"=>"1.0"}
>> rpc.call('plugin.load', 'msfd', {'ServerPort'=>44444})
=> {"result"=>"success"}

Calling netstat -tulpn:

Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name    
tcp        0      0 127.0.0.1:55554         0.0.0.0:*               LISTEN      -                   
tcp        0      0 127.0.0.1:55553         0.0.0.0:*               LISTEN      -                   
tcp        0      0 127.0.0.1:44627         0.0.0.0:*               LISTEN      -   <-- Wrong port

After

metasploit-framework on  18545-use-hash-with-indifferent-access via 💎 v3.0.5 via ⍱ 
❯ sudo bundle exec './msfrpcd -a 127.0.0.1 -P root'                 
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
[*] MSGRPC starting on 127.0.0.1:55553 (SSL):Msg...
[*] MSGRPC backgrounding at 2023-12-11 15:51:16 +0000...
[*] MSGRPC background PID 33325
                                                                                                                                                            

metasploit-framework on  18545-use-hash-with-indifferent-access via 💎 v3.0.5 via ⍱ 
❯ sudo bundle exec './msfrpc -a 127.0.0.1 -P root'                  
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
[*] The 'rpc' object holds the RPC client interface
[*] Use rpc.call('group.command') to make RPC calls

>> rpc.call('core.version')
=> {"version"=>"6.3.46-dev-479190acf6", "ruby"=>"3.1.2 x86_64-linux-gnu 2022-04-12", "api"=>"1.0"}
>> rpc.call('plugin.load', 'msfd', {'ServerPort'=>44444})
=> {"result"=>"success"}

Calling ntestat -tulpn:

Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name    
tcp        0      0 127.0.0.1:55553         0.0.0.0:*               LISTEN      -                   
tcp        0      0 127.0.0.1:44627         0.0.0.0:*               LISTEN      -                   
tcp        0      0 127.0.0.1:44444         0.0.0.0:*               LISTEN      -  <-- Correct port

[sjanusz-r7]

Release Notes

rpc_plugin has been updated to correctly use the provided plugin options.