clean up code duplication #18835
Merged
clean up code duplication #18835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cgranleese-r7 - was there anything else from the feedback in #18763 that you were wanting to pull into this PR too? |
|
I'll take a proper look at this now that the new session type work has died down. Sorry about the wait. |
zgoldman-r7
force-pushed
the
mssql-session-modules-fast-follow
branch
from
196cd92
to
7ce91df
Compare
Release NotesThis PR reduces code duplication in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #18763
Removes redundant code from recent change.
To test:
./msfconsole -qfeatures set mssql_session_type truesaveexituse mssql_loginget a session with
run CreateSession=trueuse mssql_payloadmake sure that still works as expected