Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the new DNS command #18868

Merged
merged 1 commit into from Mar 12, 2024

Conversation

zeroSteiner
Copy link
Contributor

@zeroSteiner zeroSteiner commented Feb 20, 2024

This adds documentation to the site for the new DNS command as added in #18809.

Verification

List the steps needed to make sure this thing works

  • Read through the documentation
  • Make sure it makes sense
  • Ask any clarifying questions

@smcintyre-r7 smcintyre-r7 added docs rn-documentation release notes for Metasploit Framework documentation labels Feb 20, 2024

## The DNS command
Metasploit's DNS configuration is controlled by the `dns` command which has multiple subcommands. This command is only
available when the `dns_feature` is enabled (`set feature dns_feature true`). Once enabled, the current configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's implied here but maybe explicitly mention that the dns_feature by default is disabled.
Also does the dns_feature require a database to be connected to metasploit? If so it might be worth mentioning that here.

@cdelafuente-r7 cdelafuente-r7 self-assigned this Mar 11, 2024
docs/metasploit-framework.wiki/How-to-Configure-DNS.md Outdated Show resolved Hide resolved
docs/metasploit-framework.wiki/How-to-Configure-DNS.md Outdated Show resolved Hide resolved
docs/metasploit-framework.wiki/How-to-Configure-DNS.md Outdated Show resolved Hide resolved
dns add --rule * static system 192.0.2.1
```

Define a rule in the first position to handle all queries for `*.lab.lan` using an upstream server contacted through
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it defined in the first position? I was under the impression --index should be used to add a rule in a specific position.

Also, the example specifies an upstream DNS server (192.0.2.1)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, the text should be updated to note that the default behavior is to append the rule to the end.

@cdelafuente-r7
Copy link
Contributor

Thanks @zeroSteiner ! Everything looks good now. I'll go ahead and land it.

@cdelafuente-r7 cdelafuente-r7 merged commit f4fedc2 into rapid7:master Mar 12, 2024
33 of 34 checks passed
@cdelafuente-r7
Copy link
Contributor

Release Notes

This adds documentation for the new DNS command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs rn-documentation release notes for Metasploit Framework documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants