Fix saving and loading DNS rules from the config #18944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zeroSteiner. This looks good to me. I was able to reproduce the issue and confirm these changes fix it. |
Release NotesThis fixes an issue when saving and loading DNS rules from the config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug I noticed in the new DNS changes from #18809. Basically two different key names were being used to save and load the resolver rules. This meant that the rules were saved under one name and loaded under another which meant the rules wouldn't be loaded and DNS would be broken.
dns reset-configand at least one should be populated)savecommanddnscommand, see that the rule was loaded