Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The DNS feature requires a restart, so flag it #18949

Merged
merged 1 commit into from Mar 12, 2024

Conversation

zeroSteiner
Copy link
Contributor

@zeroSteiner zeroSteiner commented Mar 12, 2024

This updates the DNS feature definition in the feature manager to:

  1. Mark that it requires the framework to be restarted in order for it to be activated (because the resolver attribute on the framework instance needs to be set)
  2. Rename it from DNS_FEATURE to DNS because the FEATURE suffix is redundant in this case and inconsistent with the other names

Fixes #18948

Verification

Demo

image

Also rename DNS_FEATURE to simply DNS because in this context, the
FEATURE suffix is redundant.
@cdelafuente-r7 cdelafuente-r7 merged commit a366f6a into rapid7:master Mar 12, 2024
48 checks passed
@cdelafuente-r7
Copy link
Contributor

Thank you @zeroSteiner for fixing this, I just updated the wording as we discussed in this commit

@cdelafuente-r7
Copy link
Contributor

cdelafuente-r7 commented Mar 12, 2024

Release Notes

This updates the DNS feature to notify the user a restart is required when the feature is enabled or disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug library rn-fix release notes fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

DNS feature stops working when trying to use it before enabling the feature
3 participants