-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust multiple DNS related things #18971
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63b3ad2
to
dbc116c
Compare
Keep the first line blank for consistency with rules and sort hostnames and addresses.
dbc116c
to
b3b6f79
Compare
|
1e47b33
Release NotesThis PR updates the documents related to DNS features, adds spell-checking and suggestions for input, and updates the layout for command output. |
Looks like this doesn't fix the help menu:
It still references 'blackhole' instead of of the config value that will work:
|
@adfoster-r7 I opened #18974 to address that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blackhole
to beblack-hole
Testing
dns add blackhole
and see a helpful suggestionDemo the static entries table updates by adding multiple IPv4 addresses and printing the table. See that
localhost
exists on its own line with the IP addresses beneath it.