Fix/dns/dot suffixed names #19012
Merged
Fix/dns/dot suffixed names #19012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
reviewed
Mar 25, 2024
| self.static_hostnames = StaticHostnames.new(hostnames: static_hosts) | ||
| self.static_hostnames.parse_hosts_file | ||
| begin | ||
| self.static_hostnames.parse_hosts_file |
There was a problem hiding this comment.
Is it possible to ignore the individual entries that break? 👀
i.e. If an invalid entry is the first line of the /etc/hosts file, we could ignore that individual host and continue to parse the rest of the file with 127.0.0.1 localhost etc
adfoster-r7
reviewed
Mar 25, 2024
| begin | ||
| self.static_hostnames.parse_hosts_file | ||
| rescue StandardError => e | ||
| @logger.error 'Failed to parse the hosts file, ignoring it' |
There was a problem hiding this comment.
Looks like the default @logger is /dev/null:
[11] pry(#<Rex::Proto::DNS::CachedResolver>)> @config[:log_file]
=> "/dev/null"
Which in this scenario might not be useful if folk want to debug issues/report framework issues; Is it possible to wire it up to the framework logging
adfoster-r7
approved these changes
Mar 25, 2024
Release NotesThis fixes an issue that was reported where msfconsole will fail to start if the user's |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that was reported where
msfconsolewill fail to start if the/etc/hostsfile contains a name ending in a.such asbad..The core of the fix is to upgrade rex-socket from 0.1.56 to 0.1.57, which pulls in the changes from rapid7/rex-socket#66. In addition to that, the
#initializemethod was updated to ignore errors that may occur when parsing the hosts file so any other issues that occur with it will not preventmsfconsolefrom starting.Testing
On a Linux system:
/etc/hostsand add a new line containing127.1.1.1 bad.dns reset-config, see thebad.hostname is defined.