Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing '-S' to cmd_notes #19129

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add missing '-S' to cmd_notes #19129

merged 2 commits into from
Apr 24, 2024

Conversation

nrathaus
Copy link
Contributor

This is a proposed fix for:
#19128

Where '-S' isn't listed in cmd_notes making this code:

notes -S 'nmap.nse.(http|rtsp)'

Doesn't work

Fix includes:

  1. Adding of the missing '-S'
  2. Sort the options alphabetically

@adfoster-r7
Copy link
Contributor

Looks like some failing tests will need to be updated 👍

@smcintyre-r7 smcintyre-r7 self-assigned this Apr 24, 2024
Copy link
Contributor

@smcintyre-r7 smcintyre-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was able to reproduce the original issue and confirm that the proposed changes fix it. I'll have this landed in a moment.

Before:

metasploit-framework (S:0 J:0) auxiliary(gather/ldap_query) > notes -S 'nmap.nse.(http|rtsp)'
[-] Invalid host parameter, nmap.nse.(http|rtsp).

After:

metasploit-framework (S:0 J:0) auxiliary(gather/ldap_query) > notes -S 'nmap.nse.(http|rtsp)'

Notes
=====

 Time                     Host           Service          Port   Protocol  Type                                   Data
 ----                     ----           -------          ----   --------  ----                                   ----
 2024-04-24 19:46:51 UTC  192.168.250.1  http             80     tcp       nmap.nse.http-server-header.tcp.80     {"output"=>"Server"}
 2024-04-24 19:46:51 UTC  192.168.250.1  ssl/http         443    tcp       nmap.nse.http-server-header.tcp.443    {"output"=>"Server"}
 ...

@smcintyre-r7 smcintyre-r7 merged commit 1c8d62a into rapid7:master Apr 24, 2024
37 checks passed
@smcintyre-r7
Copy link
Contributor

Release Notes

This fixes a bug where the notes command included an example which contained a flag that was not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy library rn-fix release notes fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants