Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display current action on module load #19185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dwelch-r7
Copy link
Contributor

Displays info about the modules current action and number of available actions to the user when they use <module_name

Example of how it looks for ldap_query
image

This is intended to help users learn that a module has actions and what the current action is proactively
I placed it behind a feature flag but defaulted it to be on so people can switch it off if they don't like the extra clutter in their terminal

Verification steps

  • use a module e.g. use auxiliary/gather/ldap_query and verify the output is correct (number of actions + selected action are accurate)
  • Turn the feature off and use the module again without rebooting and verify the output is gone
  • check that the output doesn't change for any modules without any actions

@adfoster-r7
Copy link
Contributor

I think this might be too much noise after using a module, i.e. 3-4 lines of output text everytime a module with actions is used 👀

The only existing UX I can think of is the notification about a payload being selected by default:

msf6 auxiliary(scanner/ldap/ldap_login) > use 64
[*] No payload configured, defaulting to generic/shell_reverse_tcp

It's almost a similar concept, but is more concise:

msf6 > use multi/http/tomcat_jsp_upload_bypass
[*] Using configured payload generic/shell_reverse_tcp
msf6 exploit(multi/http/tomcat_jsp_upload_bypass) > 

Following a similar pattern for actions might work

msf6 > use auxiliary/admin/kerberos/forge_ticket
[*] Using default action FORGE_SILVER
msf6 exploit(auxiliary/admin/kerberos/forge_ticket) > 

But if we followed down that path, would we expect target information to be output too? Things might start getting a bit noisey 😄

@dwelch-r7 dwelch-r7 force-pushed the display-current-action-on-module-load branch from 67b1af7 to db986af Compare May 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants