Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show regular option groups when viewing advanced options #19186

Merged

Conversation

dwelch-r7
Copy link
Contributor

Fixes the display of option groups so that the option group only displays the relevant options (regular/advanced/evasion) if any are present in the group, and only displays the group at all if it has an option to display

Also updated the tests to have an option group with mixed regular and advanced options

Verification Steps

  • use a module with grouped options e.g. use ldap_query
  • verify that the option groups appear when running options
  • verify the option groups are no longer displayed when running advanced

@adfoster-r7
Copy link
Contributor

After enabling ldap session type features set ldap_session_type true

diff:

image

@adfoster-r7 adfoster-r7 merged commit 40f7539 into rapid7:master May 20, 2024
34 checks passed
@adfoster-r7 adfoster-r7 added the rn-fix release notes fix label May 20, 2024
@adfoster-r7
Copy link
Contributor

Release Notes

Fixes a bug were the show advanced command could show normal options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants