Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<DRAFT> Updates login/scanner modules to make use of ReportSummary mixin #19220

Conversation

cgranleese-r7
Copy link
Contributor

@cgranleese-r7 cgranleese-r7 commented May 31, 2024

Note

In draft for now, blocked until #19199 is merged

Updating modules to make use of the Msf::Auxiliary::ReportSummary mixin added here #19199.

Some modules were updated with #19199 for easier testing of the mixin.

Verification

  • Start msfconsole
  • Use a login module
  • Test against a single host
  • Test against multiple hosts
  • Verify the table is output by default
  • Verify the table is not output when ShowSuccessLogins is set to false
  • Verify the module outputs the verbose output when ran against a single host

@cgranleese-r7 cgranleese-r7 added blocked Blocked by one or more additional tasks enhancement rn-enhancement release notes enhancement labels May 31, 2024
@cgranleese-r7 cgranleese-r7 force-pushed the update-login-scanner-modules-to-use-report-summary-mixin branch from 1080415 to ad6fdb5 Compare May 31, 2024 15:09
@adfoster-r7
Copy link
Contributor

Let's close and consolidate this into the existing PR - thanks! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by one or more additional tasks enhancement rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants