New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module update sap router portscanner #2012
Module update sap router portscanner #2012
Conversation
@@ -15,55 +15,98 @@ class Metasploit3 < Msf::Auxiliary | |||
|
|||
def initialize | |||
super( | |||
'Name' => 'SAPRouter Port Scanner', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this addition is breaking current indentation. Do you mind to apply your changes over the current version landed on the metasploit-framework. And just land changes, please, don't redo indentation. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry. let me blame this on rubymine :)
Processing.... |
Like the changes, my only worry is which sometimes service info could be confusing:
This time 3306 isn't a " SAP Gateway sapgw0 " but a MySQL from a host behind the SAProuter, even when I guess saprouter is used indeed to put available SAP infrastructure, I'm going to display a warning message :) (btw, it's working, finishing code review and landing, thanks @morisson !) |
Instances / wildcards also working, landing:
|
Added option for generating ports from instance numbers;
Added information on SAP default ports;
Output is now cleaner, in a table format;