Fix condition in order to fix Firefox module

[jvazquez-r7]

The actual condition is wrong, the not found should be sent if firefox isn't 17 AND firefox isn't 21, because the module supports Firefox 17 and 21 atm.

[todb-r7]

Wait, I don't get this fix. Both seem to be okay. It's a little confusing because of the inverted match operator.

Seems like this would be clearer, but maybe I'm misunderstanding the check:

unless agent =~ /Firefox\/(17|21)/

This is an or as well, but I can't see how you could ever satisfy an and. When you invert the match, or and and are going to give the same results?

[rajchandel]

please send me exploited browser link

[jvazquez-r7]

@todb-r7, at the moment Firefox 17 and 21 are supported so if the browser isn't Firefox 17 branch and isn't Firefox 21 branch send a Not Found because of the unsupported browser:

        if agent !~ /Firefox\/17/ and agent !~ /Firefox\/21/
            print_error("Browser not supported, sending 404: #{agent}")
            send_not_found(cli)
            return
        end

And, yes, your patch should also work:

unless agent =~ /Firefox\/(17|21)/
    print_error("Browser not supported, sending 404: #{agent}")
    send_not_found(cli)
    return
end

Since the ruby style guide says: "Favor unless over if for negative conditions (or control flow ||)." I'm going to make a new pull request with the @todb-r7 suggestion.

[todb]

@rajchandel, see the answer to your request at #2198 (comment)

[wchen-r7]

http://www.oldapps.com/firefox.php?old_firefox=8492

[jvennix-r7]

It's too bad we can't distinguish between Firefox 17 and Firefox ESR 17. Technically we could do it with javascriptosdetect which uses feature detection instead of useragent parsing, but my guess is that javascriptosdetect would flag ESR firefox as a "falsely reported user agent" (since the feature set won't match up) and not return anything specific as its version.