Validate datastore option "YEAR" #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The YEAR option is a numeric value, so should be OptInt in order to go through validation. [FixRM rapid7#8345] [FixRM rapid7#8344]
|
If you apply the change the module should have into account YEAR is a Fixnum and not an String. After changes I'm experiencing this crash: The code raising the exception is expecting an String on datastore['YEAR']: |
|
Processing! |
|
Looks good now, landing! |
jvazquez-r7
pushed a commit
that referenced
this pull request
Aug 26, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YEAR option is a numeric value, so should be OptInt in order to go through validation.
[FixRM #8345]
[FixRM #8344]