Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate tape_engine_8A as tape_engine_0x8a #2393

Merged
merged 1 commit into from Sep 19, 2013
Merged

Disambiguate tape_engine_8A as tape_engine_0x8a #2393

merged 1 commit into from Sep 19, 2013

Conversation

todb-r7
Copy link

@todb-r7 todb-r7 commented Sep 19, 2013

This will revisit #2358 to avoid filename collisions on Windows, Rubymine
environments, etc.

This will reopen #2358 to avoid filename collisions on Windows, Rubymine
environments, etc.
@wchen-r7
Copy link
Contributor

This collision is killing me too. OS X + good old git command.

@wvu
Copy link
Contributor

wvu commented Sep 19, 2013

Okay, landing. :P

wvu added a commit that referenced this pull request Sep 19, 2013
@wvu wvu merged commit fb72e7f into rapid7:master Sep 19, 2013
@todb-r7
Copy link
Author

todb-r7 commented Sep 19, 2013

Verification:

  • See that ./modules/exploits/windows/brightstor/tape_engine_8a.rb is removed.
  • See that ./modules/exploits/windows/brightstor/tape_engine_8A.rb remains.
  • See that ./modules/exploits/windows/brightstor/tape_engine_0x8a.rb is added.
  • Running module/exploit/windows/brightstor/tape_engine_8A from msfconsole produces the appropriate deprecation banner:
[!] ************************************************************************
[!] *                      This module is deprecated!                      *
[!] *              It will be removed on or about 2013-09-26               *
[!] *       Use exploit/windows/brightstor/tape_engine_0x8a instead        *
[!] ************************************************************************

@todb-r7
Copy link
Author

todb-r7 commented Sep 19, 2013

@wchen-r7 is the git error recoverable? I don't hit this on Linux, obviously.

@wchen-r7
Copy link
Contributor

No, it will always tell me either I have tape_engine_8A.rb modified, or I have tape_engine_8a.rb modified. Doesn't matter what I do. I'm not messing w/ this right now because I'm in the middle of a module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants