Include the post requires until #2354 lands #2394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another one that needs the manual require. See #2354, which will solve this once and for all on Sep 24,2013.
In the meantime, please ensure that if you're using
Msf::Post
mixins, you require the appropriate mixin in the module.Verification
Set up a test branch. Don't ever land this branch upstream since it's destructive.
git checkout upstream-master
git checkout -b test-2354
# Don't land this branch since you're deleting stuff.git rm -rf modules/post/*
git commit -m "Never land this"
Test the failure condition:
git checkout upstream-master modules/exploits/windows/local/ms13_005_hwnd_broadcast.rb
Test the fix:
git fetch upstream
git checkout upstream/pr/2394 modules/exploits/windows/local/ms13_005_hwnd_broadcast.rb
msf > info exploit/windows/local/ms13_005_hwnd_broadcast
Switch back to master, and then land this PR as normal.