Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the post requires until #2354 lands #2394

Merged
merged 1 commit into from Sep 24, 2013
Merged

Include the post requires until #2354 lands #2394

merged 1 commit into from Sep 24, 2013

Conversation

todb-r7
Copy link

@todb-r7 todb-r7 commented Sep 19, 2013

Another one that needs the manual require. See #2354, which will solve this once and for all on Sep 24,2013.

In the meantime, please ensure that if you're using Msf::Post mixins, you require the appropriate mixin in the module.

Verification

Set up a test branch. Don't ever land this branch upstream since it's destructive.

  • git checkout upstream-master
  • git checkout -b test-2354 # Don't land this branch since you're deleting stuff.
  • git rm -rf modules/post/*
  • git commit -m "Never land this"

Test the failure condition:

  • git checkout upstream-master modules/exploits/windows/local/ms13_005_hwnd_broadcast.rb
  • See the error on loading as reported by d0rmous3: http://pastebin.com/8XaJxbdz

Test the fix:

  • git fetch upstream
  • git checkout upstream/pr/2394 modules/exploits/windows/local/ms13_005_hwnd_broadcast.rb
  • See no error.
  • Get info on the module: msf > info exploit/windows/local/ms13_005_hwnd_broadcast

Switch back to master, and then land this PR as normal.

Another one that needs the manual require. See #2354
@wvu
Copy link
Contributor

wvu commented Sep 20, 2013

The paste is gone, but I can imagine what was in it.

@wvu
Copy link
Contributor

wvu commented Sep 24, 2013

Processing.

wvu added a commit that referenced this pull request Sep 24, 2013
@wvu wvu merged commit ef72b30 into rapid7:master Sep 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants