Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release time fixes to modules #2522

Merged
merged 1 commit into from Oct 14, 2013
Merged

Release time fixes to modules #2522

merged 1 commit into from Oct 14, 2013

Conversation

todb-r7
Copy link

@todb-r7 todb-r7 commented Oct 14, 2013

  • Period at the end of a description.
  • Methods shouldn't be meth_name! unless the method is destructive.
  • "Setup" is a noun, "set up" is a verb.
  • Use the clunky post module naming convention.

Release time fixes to modules
63e40f9 
  * Period at the end of a description.
  * Methods shouldn't be meth_name! unless the method is destructive.
  * "Setup" is a noun, "set up" is a verb.
  * Use the clunky post module naming convention.
@wvu
Copy link
Contributor

wvu commented Oct 14, 2013

Looks good.

wvu added a commit that referenced this pull request Oct 14, 2013
@wvu
Land #2522, @todb-r7's pre-release module fixes
31dc7c0
@wvu wvu merged commit 63e40f9 into rapid7:master Oct 14, 2013
@todb-r7 todb-r7 deleted the fixup-release branch November 18, 2013 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@todb-r7 @wvu