Release fixes #2558
Merged
Release fixes #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 21, 2013 13:33
* Lua is not an acronym * Adds an OSVDB ref * credit @jvazquez-r7, not HD, for the Windows CMD thing
Even if the OS detection returns non-Win7, maybe it's Win 8 or something where it'll still work. We rarely bail out on checks like these. If I'm crazy, feel free to skip or revert this commit (it shouldn't hold up the release at all) For details on this module, see #2503. I don't see any comments about this line in particular
|
Looks good for me, merging. |
wchen-r7
added a commit
that referenced
this pull request
Oct 21, 2013
|
Thanks @wchen-r7 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this is the usual round of pre-release fixes, pay special attention to c1954c4. If you hate it, don't hesitate to not land that commit. I just was baffled by it, seems overly conservative compared to our usual.