Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a handful of msftidy warnings, and XXX SSL #2628

Merged
merged 2 commits into from Nov 12, 2013
Merged

Fix a handful of msftidy warnings, and XXX SSL #2628

merged 2 commits into from Nov 12, 2013

Conversation

todb-r7
Copy link

@todb-r7 todb-r7 commented Nov 12, 2013

Marked the SSL stuff as something that needs to be resolved in order to
fix a future bug in datastore manipulation. Also, fixed some whitespace
and exec complaints.

Somewhat related to https://dev.metasploit.com/redmine/issues/8498 because of the datastore manipulation, but mostly this is just some release-time fixup.

(@bturner-r7, none of this is critical for you, take it or leave it -- should be landed in master regardless of your designs)

Tod Beardsley added 2 commits November 11, 2013 21:23
Marked the SSL stuff as something that needs to be resolved in order to
fix a future bug in datastore manipulation. Also, fixed some whitespace
and exec complaints

[SeeRM #8498]
@wchen-r7
Copy link
Contributor

This looks safe to me but I don't have the guts to push anything anymore.

@todb
Copy link
Contributor

todb commented Nov 12, 2013

They're pretty easy changes. Don't be frightened. :)
On Nov 11, 2013 11:47 PM, "sinn3r" notifications@github.com wrote:

This looks safe to me but I don't have the guts to push anything anymore.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2628#issuecomment-28270147
.

@wchen-r7 wchen-r7 merged commit 6599370 into rapid7:master Nov 12, 2013
@todb-r7 todb-r7 deleted the release-fixes branch March 10, 2014 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants